Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSC bridge multisig improvements #1424

Closed
Tracked by #1437
robvanmieghem opened this issue Apr 26, 2023 · 7 comments
Closed
Tracked by #1437

BSC bridge multisig improvements #1424

robvanmieghem opened this issue Apr 26, 2023 · 7 comments
Assignees
Milestone

Comments

@robvanmieghem
Copy link
Contributor

robvanmieghem commented Apr 26, 2023

@DylanVerstraete
Copy link
Contributor

DylanVerstraete commented Apr 26, 2023

I would make this an issue to improve all bridges for TF at once. To rewrite the bridges for eth / tfchain in a single project (preferrably rust)

Shared functionality:

  • Stellar transaction streaming
  • Signing transactions
  • Communicating transactions between signer peers
  • ..

@robvanmieghem
Copy link
Contributor Author

@DylanVerstraete That's a different story imo

@DylanVerstraete
Copy link
Contributor

I don't really agree with that, because to "improve" the things stated above, it will require some development work which can be directed towards a "fresh" start where we design the stuff from the bottom up again with all the knowledge we currently have. I believe redoing it will be the better solution here.

@DylanVerstraete
Copy link
Contributor

Mainly because a lot of the functionality can be shared between the 2 bridges we have right now.

@xmonader
Copy link
Contributor

What is the status here, still feasible for 3.11? also should it still be linked to grid releases or can be in a separate project? @robvanmieghem

@robvanmieghem robvanmieghem removed this from 3.11.x Jun 20, 2023
@robvanmieghem robvanmieghem added this to the later milestone Jun 20, 2023
@robvanmieghem robvanmieghem modified the milestones: later, 3.11 Jul 7, 2023
@robvanmieghem robvanmieghem moved this to In Progress in 3.11.x Jul 7, 2023
@robvanmieghem robvanmieghem removed this from 3.11.x Jul 7, 2023
@robvanmieghem robvanmieghem moved this to In Progress in 3.13.x Jul 7, 2023
@despiegk
Copy link
Contributor

lets just make sure its reliable for now, no need to rewrite, make sure we have it documented in our development docs (internal) / mdbook

@robvanmieghem robvanmieghem modified the milestones: 3.11, 3.12 Jul 28, 2023
@robvanmieghem
Copy link
Contributor Author

Tested, small updates updated the docs to use the same code as the Ethereum bridge: https://github.com/threefoldfoundation/tft/releases/tag/v1.5.0
Deploying: https://github.com/threefoldtech/tf_operations/issues/1832

@github-project-automation github-project-automation bot moved this from In Progress to Done in 3.13.x Nov 22, 2023
@ramezsaeed ramezsaeed mentioned this issue Dec 5, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants