Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't add new packages with --local flag #3358

Open
OmarElawady opened this issue Dec 19, 2021 · 1 comment
Open

Can't add new packages with --local flag #3358

OmarElawady opened this issue Dec 19, 2021 · 1 comment
Milestone

Comments

@OmarElawady
Copy link
Contributor

stacktrace:

  File "/home/omar/codescalers/js-sdk/jumpscale/servers/threebot/threebot.py", line 544, in add
    self.install(package)
    │    │       └ <jumpscale.servers.threebot.threebot.Package object at 0x7fa61af9ffd0>
    │    └ <function PackageManager.install at 0x7fa62054fca0>
    └ PackageManager(
        instance_name='default',
        parent=ThreebotServer(instance_name_='default'),
        packages={'auth': {'path': '/...

  File "/home/omar/codescalers/js-sdk/jumpscale/servers/threebot/threebot.py", line 663, in install
    package.start()
    │       └ <function Package.start at 0x7fa62054f550>
    └ <jumpscale.servers.threebot.threebot.Package object at 0x7fa61af9ffd0>

  File "/home/omar/codescalers/js-sdk/jumpscale/servers/threebot/threebot.py", line 370, in start
    self.module.start(**self.kwargs)
    │    │              │    └ {}
    │    │              └ <jumpscale.servers.threebot.threebot.Package object at 0x7fa61af9ffd0>
    │    └ <property object at 0x7fa62053d360>
    └ <jumpscale.servers.threebot.threebot.Package object at 0x7fa61af9ffd0>

  File "/home/omar/codescalers/js-sdk/jumpscale/packages/threebot_deployer/package.py", line 39, in start
    location_actors_443 = j.sals.nginx.main.websites.default_443.locations.get(name="threebot_deployer_actors")
                          │ └ <property object at 0x7fa624baac20>
                          └ <jumpscale.loader.J object at 0x7fa624b9ec70>

AttributeError: 'Factory' object has no attribute 'default_443'

It looks like the 443 should be 8443

@abom
Copy link
Contributor

abom commented Dec 19, 2021

Yes, the code should be hardened to handle current used port, defined in jumpscale/sals/nginx/nginx.py

class PORTS:
HTTP = 80
HTTPS = 443

@xmonader xmonader added this to the later milestone Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants