Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Srtool failed within the release workflow #1014

Closed
sameh-farouk opened this issue Oct 7, 2024 · 3 comments
Closed

Srtool failed within the release workflow #1014

sameh-farouk opened this issue Oct 7, 2024 · 3 comments
Assignees
Labels
type_bug Something isn't working
Milestone

Comments

@sameh-farouk
Copy link
Member

Describe the bug

Srtool failed within the release workflow with this error

β•‘ 🧰 Substrate Runtime Toolbox - srtool v0.16.0 🧰
  β•‘ - by Chevdor -
  info: override toolchain for '/build' set to '1.81.0-x86_64-unknown-linux-gnu'
  β•‘ πŸ— Building tfchain-runtime as release using rustc 1.81.0 (eeb90cda1 2024-09-04)
  β•‘ ⏳ That can take a little while, be patient... subsequent builds may be faster.
  β•‘ Since you have to wait a little, you may want to learn more about Substrate runtimes:
  β•‘ https://docs.substrate.io/learn/architecture/
  β•‘ Updating crates.io index
  β•‘ Updating git repository `[https://github.com/paritytech/polkadot-sdk`](https://github.com/paritytech/polkadot-sdk%60)
  β•‘ Updating git repository `[https://github.com/encointer/substrate-fixed.git`](https://github.com/encointer/substrate-fixed.git%60)
  β•‘ Updating git repository `[https://github.com/pendulum-chain/substrate-stellar-sdk`](https://github.com/pendulum-chain/substrate-stellar-sdk%60)
  β•‘ Updating git repository `[https://github.com/w3f/ring-vrf`](https://github.com/w3f/ring-vrf%60)
  β•‘ error: no matching package named `bandersnatch_vrfs` found
  β•‘ location searched: https://github.com/w3f/ring-vrf?rev=3119f51#3119f51b
  β•‘ required by package `sp-core v21.0.0 (https://github.com/paritytech/polkadot-sdk?tag=polkadot-v1.1.0#f60318f6)`
  β•‘ ... which satisfies git dependency `sp-core` (locked to 21.0.0) of package `tfchain v2.9.2 (/build/node)`
  parse error: Invalid numeric literal at line 1, column 4
  Error: Process completed with exit code 4.
@sameh-farouk sameh-farouk added type_bug Something isn't working tfchain tfchain issue and removed tfchain tfchain issue labels Oct 7, 2024
@sameh-farouk sameh-farouk self-assigned this Oct 7, 2024
@sameh-farouk sameh-farouk moved this to Accepted in 3.15.x Oct 7, 2024
@sameh-farouk sameh-farouk moved this from Accepted to In Progress in 3.15.x Oct 7, 2024
@sameh-farouk sameh-farouk added this to the 2.9.0 milestone Oct 7, 2024
@sameh-farouk
Copy link
Member Author

Update:
I was able to reproduce the issue locally using Act for further debugging.
The Srtool-Action, by default, pulls the latest Srtool image, which was recently updated to 1.81.0. This version uses rustc 1.81.0 to build the TFChain runtime. However, TFChain and polkadot-sdk 1.1.0, which we're currently using, were tested with rustc 1.70.0. The last known working Srtool version from our actions log is 1.77.0.

We should probably pin this version for now, as we are not up to date with polkadot-sdk upstream.

@sameh-farouk
Copy link
Member Author

sameh-farouk commented Oct 7, 2024

Update:
PR awaiting review

@sameh-farouk sameh-farouk moved this from In Progress to Pending Review in 3.15.x Oct 7, 2024
@sameh-farouk sameh-farouk moved this from Pending Review to In Verification in 3.15.x Oct 7, 2024
@sameh-farouk
Copy link
Member Author

Verified,
CI finished, TFChain runtime built and 2.9.2 release created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type_bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

1 participant