Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Farm Name input validation #1686

Closed
A-Harby opened this issue Dec 13, 2023 · 7 comments
Closed

Farm Name input validation #1686

A-Harby opened this issue Dec 13, 2023 · 7 comments
Assignees
@amiraabouhadid
Labels
dashboard type_bug Something isn't working
Milestone
2.3.0

Comments

@A-Harby
Copy link
Contributor

A-Harby commented Dec 13, 2023

Description

Devnet, 28d6c07.

Adding farm input validation will prevent this error message.

image

The old input validation for Farm Name was [maximum 40 ascii characters, no spaces, only -, _ are allowed as special characters]. I don't know if it was changed or not.
@A-Harby A-Harby added type_bug Something isn't working dashboard labels Dec 13, 2023
@zaelgohary zaelgohary added this to the 2.3.0 milestone Dec 14, 2023
@zaelgohary
Copy link
Contributor

Check validation in tf chain and same validation should be applied here.

@zaelgohary zaelgohary moved this to Accepted in 3.13.x Dec 14, 2023
@amiraabouhadid amiraabouhadid moved this from Accepted to In Progress in 3.13.x Dec 17, 2023
@amiraabouhadid
Copy link
Contributor

Investigative work:
looked for validation on the tf chain

@amiraabouhadid
Copy link
Contributor

amiraabouhadid commented Dec 18, 2023 •
edited
Loading

fixed:
image

Screenshot from 2023-12-18 13-22-19

@amiraabouhadid amiraabouhadid moved this from In Progress to In Verification in 3.13.x Dec 18, 2023
@amiraabouhadid amiraabouhadid mentioned this issue Dec 18, 2023
Merged
@A-Harby
Copy link
Contributor Author

A-Harby commented Dec 18, 2023

6d0ec3d
Not released yet.
image

@A-Harby A-Harby moved this from In Verification to Pending Deployment in 3.13.x Dec 18, 2023
@amiraabouhadid amiraabouhadid moved this from Pending Deployment to Pending review in 3.13.x Dec 18, 2023
@amiraabouhadid
Copy link
Contributor

moved back to pending review, was put in verification by mistake

@amiraabouhadid amiraabouhadid moved this from Pending review to In Verification in 3.13.x Dec 19, 2023
@A-Harby
Copy link
Contributor Author

A-Harby commented Dec 21, 2023

Verified,

image
image
image
image
image

@A-Harby A-Harby moved this from In Verification to Done in 3.13.x Dec 21, 2023
@ramezsaeed
Copy link
Contributor

verified:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amiraabouhadid amiraabouhadid

Labels
dashboard type_bug Something isn't working
Projects
No open projects
3.13.x
Status: Done
Milestone
2.3.0
Development

No branches or pull requests
4 participants
@ramezsaeed @zaelgohary @amiraabouhadid @A-Harby