Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 [Bug]: No error appeared when writing characters in calculator #2745

Closed
1 task done
AlaaElattar opened this issue May 21, 2024 · 2 comments
Closed
1 task done
Assignees
Labels
dashboard type_bug Something isn't working
Milestone

Comments

@AlaaElattar
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

which package/s did you face the problem with?

Dashboard

What happened?

  • I typed characters at the balance field in calculator, and the field accepted them.

Steps To Reproduce

Calculator page in dashboard

which network/s did you face the problem on?

Dev

version

Twin ID/s

Node ID/s

Farm ID/s

Contract ID/s

Relevant screenshots/screen records

image

Relevant log output

-
@AlaaElattar AlaaElattar added the type_bug Something isn't working label May 21, 2024
@ramezsaeed ramezsaeed added this to the 2.5.0 milestone May 27, 2024
@AhmedHanafy725 AhmedHanafy725 moved this to Accepted in 3.14.x May 27, 2024
@Mahmoud-Emad Mahmoud-Emad self-assigned this May 29, 2024
@Mahmoud-Emad Mahmoud-Emad moved this from Accepted to In Progress in 3.14.x May 29, 2024
@Mahmoud-Emad
Copy link
Contributor

Issue update

Work done

Fixed entering characters value in the balance field

Changes

  • Added the 'isInt' validation rule to check the entered value and display an error in case the entered value wasn't an integer.

Screenshots/Video

  • image

@Mahmoud-Emad Mahmoud-Emad moved this from In Progress to Pending Review in 3.14.x May 29, 2024
@Mahmoud-Emad Mahmoud-Emad moved this from Pending Review to In Verification in 3.14.x May 29, 2024
@khaledyoussef24
Copy link
Contributor

version : 2b7ab4e
verified user now can not insert a character in the fields without errors

Image

https://app.testlodge.com/a/26076/projects/40893/suites/234374?expand_section=430165#case_4292394

@khaledyoussef24 khaledyoussef24 moved this from In Verification to Done in 3.14.x Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard type_bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

4 participants