Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 [Bug]: Enhance the load domains behavior #2982

Closed
1 task done
Mahmoud-Emad opened this issue Jun 13, 2024 · 4 comments
Closed
1 task done

🐞 [Bug]: Enhance the load domains behavior #2982

Mahmoud-Emad opened this issue Jun 13, 2024 · 4 comments
Assignees
Labels
type_bug Something isn't working
Milestone

Comments

@Mahmoud-Emad
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

which package/s did you face the problem with?

Dashboard

What happened?

While testing the dashboard, I noticed that 2 requests are invoked when the reload icon is pressed. Both of them have the same response/result. Are they both needed?

the ret_count query is set to one of them, it can be done by removing the first one and send only one request with the ret_count if needed

Steps To Reproduce

  1. Go to the dashboard
  2. Connect your wallet
  3. Deploy a micro VM
  4. Go to attach a domain to it
  5. Inspect the page and Go to the network tab
  6. Press on the reload button beside the domains select
  7. Watch the network tab and you'll see that two requests are sent to the server and only the difference is that the ret_count query is set to one of them

which network/s did you face the problem on?

Dev

version

b4861f5

Twin ID/s

143

Node ID/s

No response

Farm ID/s

No response

Contract ID/s

No response

Relevant screenshots/screen records

Screencast.from.06-13-2024.08.46.01.AM.webm

Relevant log output

N/A
@Mahmoud-Emad Mahmoud-Emad added the type_bug Something isn't working label Jun 13, 2024
@MohamedElmdary
Copy link
Member

MohamedElmdary commented Jun 13, 2024

This is not possible for our implementation as we don't load 1st page as requested before so we need to get count then load a random page so we might load 3rd page before 1st one

@ramezsaeed ramezsaeed added this to the 2.6.0 milestone Jun 24, 2024
@AhmedHanafy725 AhmedHanafy725 moved this to Accepted in 3.15.x Jun 24, 2024
@0oM4R 0oM4R self-assigned this Jul 4, 2024
@0oM4R 0oM4R moved this from Accepted to In Progress in 3.15.x Jul 4, 2024
@0oM4R 0oM4R moved this from In Progress to Pending Review in 3.15.x Jul 4, 2024
@0oM4R 0oM4R moved this from Pending Review to In Verification in 3.15.x Aug 1, 2024
@khaledyoussef24 khaledyoussef24 moved this from In Verification to Accepted in 3.15.x Aug 6, 2024
@0oM4R
Copy link
Contributor

0oM4R commented Aug 6, 2024

its impossible to make it only one request. We enhanced the load domains by reducing the size of the request and set it to zero
you can validate it by checking the size flag here
https://gridproxy.dev.grid.tf/nodes?ipv4=true&ipv6=true&available_for=201&status=up&page=1&size=0&ret_count=true&sort_by=free_cru&sort_order=desc&domain=true

@0oM4R 0oM4R moved this from Accepted to In Verification in 3.15.x Aug 7, 2024
@khaledyoussef24
Copy link
Contributor

verified on devnet
version : a542a73

Image
Image

the request size is 0 now

@khaledyoussef24 khaledyoussef24 moved this from In Verification to Done in 3.15.x Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type_bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

5 participants