Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change drawer sync calls #8166

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Conversation

wmontwe
Copy link
Member

@wmontwe wmontwe commented Sep 24, 2024

Resolves #8146

Add a syn all accounts button to the side rail.

Depends on #8165

@cketti
Copy link
Member

cketti commented Sep 25, 2024

image

It would be nice if the icons aligned with the "Manage folders" and "Hide accounts" icons. I confirmed with layout inspector (build.gradle.kts has to be changed to not exclude "META-INF/*.version") that it's close, but not quite the same y-coordinates.

@wmontwe
Copy link
Member Author

wmontwe commented Sep 25, 2024

This is an layouting issue as the column is offset by 1 dp caused by the divider. I added an uneven spacer to compensate this. The LazyColumn is not affected by that.

@cketti
Copy link
Member

cketti commented Sep 25, 2024

I don't think the divider is the issue.

The SettingListItems in the drawer are 56dp in height by default. The icon is vertically centered.
To horizontally align the icons, the SettingItem should have the same height and vertically center the icons.

This will fail to align the icons when the text in SettingItem wraps to multiple lines. But it should work for the default case where it's just one line.

@wmontwe
Copy link
Member Author

wmontwe commented Sep 25, 2024

The outer column is placed at an uneven y position and that's causing the alignment issue.

@wmontwe wmontwe merged commit 056e286 into thunderbird:main Sep 25, 2024
2 checks passed
@wmontwe wmontwe deleted the change-drawer-sync-calls branch September 25, 2024 11:43
@cketti
Copy link
Member

cketti commented Sep 25, 2024

Both views are aligned to the bottom of the drawer. It's just a matter of replicating the layout behavior. See cketti@95ac9ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve drawer sync mechanism
2 participants