-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Welcome / Get started screen has vertical content overflow #8458
Comments
Auto-sizing text is interesting, I just talked to folks about this recently in a different context. Thanks for sharing. What I think we need here is actually a more auto-sizing logo, that looks pretty big. |
Can you assign this to me? I'll update the logo to be auto-sizing |
Hello @kewisch ! |
Hi @SttApollo @Renekakpo, thanks for stepping up on this! Obviously you shouldn't both work on this issue and @SttApollo was asking first, so I'd give first dibs to @SttApollo. You can just go ahead and send a pull request, or if it turns out to be more complex than setting a maximum height then let us know what your approach is. @Renekakpo are there any other issues you're interested in? If we don't hear back from @SttApollo for a while do check in and you can pick up this one. |
@kewisch Thanks for the reply. I would recommend a responsive sizing with aspect ratio preservation because:
If @SttApollo doesn't reply in time you can assign me this issue. Meanwhile, I'll check if I can help with any other issue. |
I'm on it. thanks! @kewisch |
Checklist
App
Thunderbird for Android
App version
8.0
Where did you get the app from?
Google Play
Android version
8.0.0
Device model
Asus Zenphone 3 Zoom (ZE553KL)
Steps to reproduce
I was suggested to check my font and accessibility settings, and they're all still the default.
Expected behavior
This is my opinion, but I would expect no content (text, in this case) to be going beyond any screen edge on the very first screen of an app, especially with visible clipping. I feel that scrolling should not be a thing, here.
No functionality is affected, this a purely esthetical matter. If this isn't a real issue, feel free to close it.
Actual behavior
The bottom text ("Developed by a dedicated team at MZLA...") is slightly clipped and, together with the padding below, makes it so you can scroll up and down on the first screen, even though it's practically useless. Style points may be awarded for triggering the scroll-limit animations.
I tested the most recent beta on the Play Store (8.0b5) to see if it was any different. Instead of clipping and slightly overflowing, the text is buried beyond the bottom of the screen and unnoticeable unless the user scrolls down on their own initiative.
That seems wrong, but in a different sense. I don't know whether this change was intentional or not, given that the text is different (Thunderbird vs. Thunderbird Beta).
Logs
No response
The text was updated successfully, but these errors were encountered: