Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome / Get started screen has vertical content overflow #8458

Open
2 tasks done
fmbarina opened this issue Oct 31, 2024 · 7 comments
Open
2 tasks done

Welcome / Get started screen has vertical content overflow #8458

fmbarina opened this issue Oct 31, 2024 · 7 comments
Assignees
Labels
good first issue Ideal for newcomers to start contributing type: bug Something is causing incorrect behavior or errors

Comments

@fmbarina
Copy link

fmbarina commented Oct 31, 2024

Checklist

  • I have used the search function to see if someone else has already submitted the same bug report.
  • I will describe the problem with as much detail as possible.

App

Thunderbird for Android

App version

8.0

Where did you get the app from?

Google Play

Android version

8.0.0

Device model

Asus Zenphone 3 Zoom (ZE553KL)

Steps to reproduce

  1. Install app for the first time or clear app data
  2. Open Thunderbird
  3. Try scrolling?

I was suggested to check my font and accessibility settings, and they're all still the default.

Expected behavior

This is my opinion, but I would expect no content (text, in this case) to be going beyond any screen edge on the very first screen of an app, especially with visible clipping. I feel that scrolling should not be a thing, here.

No functionality is affected, this a purely esthetical matter. If this isn't a real issue, feel free to close it.

Actual behavior

The bottom text ("Developed by a dedicated team at MZLA...") is slightly clipped and, together with the padding below, makes it so you can scroll up and down on the first screen, even though it's practically useless. Style points may be awarded for triggering the scroll-limit animations.

tb81 tb82 tb83

I tested the most recent beta on the Play Store (8.0b5) to see if it was any different. Instead of clipping and slightly overflowing, the text is buried beyond the bottom of the screen and unnoticeable unless the user scrolls down on their own initiative.

tb-beta tb-betb

That seems wrong, but in a different sense. I don't know whether this change was intentional or not, given that the text is different (Thunderbird vs. Thunderbird Beta).

Logs

No response

@fmbarina fmbarina added type: bug Something is causing incorrect behavior or errors unconfirmed Newly reported issues awaiting triage or confirmation labels Oct 31, 2024
@rezazarchi
Copy link
Contributor

rezazarchi commented Nov 1, 2024

Yesterday, Google announced that they added auto-sizing text to the Compose and it will be stable on next Compose version. I think we could potentially use this feature to adjust text sizes automatically, eliminating the need for scrollable screens. [1] [2]

@kewisch
Copy link
Member

kewisch commented Nov 4, 2024

Auto-sizing text is interesting, I just talked to folks about this recently in a different context. Thanks for sharing.

What I think we need here is actually a more auto-sizing logo, that looks pretty big.

@kewisch kewisch added this to the Thunderbird 9.0 milestone Nov 4, 2024
@kewisch kewisch removed the unconfirmed Newly reported issues awaiting triage or confirmation label Nov 4, 2024
@kewisch kewisch added the good first issue Ideal for newcomers to start contributing label Nov 15, 2024
@SttApollo
Copy link

SttApollo commented Nov 23, 2024

Can you assign this to me? I'll update the logo to be auto-sizing

@Renekakpo
Copy link

Hello @kewisch !
I'm interested in working on the issue related to the logo size and would like to be assigned. Could you assign this to me?

@kewisch
Copy link
Member

kewisch commented Nov 26, 2024

Hi @SttApollo @Renekakpo, thanks for stepping up on this! Obviously you shouldn't both work on this issue and @SttApollo was asking first, so I'd give first dibs to @SttApollo. You can just go ahead and send a pull request, or if it turns out to be more complex than setting a maximum height then let us know what your approach is.

@Renekakpo are there any other issues you're interested in? If we don't hear back from @SttApollo for a while do check in and you can pick up this one.

@Renekakpo
Copy link

@kewisch Thanks for the reply. I would recommend a responsive sizing with aspect ratio preservation because:

  • It dynamically adapts to different screen sizes
  • Preserves logo aspect ratio
  • Works across various device configurations
  • Simple to implement and customize

If @SttApollo doesn't reply in time you can assign me this issue. Meanwhile, I'll check if I can help with any other issue.

@SttApollo
Copy link

SttApollo commented Nov 26, 2024

I'm on it. thanks! @kewisch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Ideal for newcomers to start contributing type: bug Something is causing incorrect behavior or errors
Projects
None yet
Development

No branches or pull requests

5 participants