Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo / Redo is not keyboard layout agnostic #1397

Closed
realansgar opened this issue Nov 8, 2023 · 3 comments
Closed

Undo / Redo is not keyboard layout agnostic #1397

realansgar opened this issue Nov 8, 2023 · 3 comments
Labels
bug Something isn't working Priority Implement this asap

Comments

@realansgar
Copy link

Describe the bug
I use a German keyboard layout. When I press Ctrl+Z, no undo happens. Instead, it happens when I press Ctrl+Y. This is because on a German keyboard layout, the Z and Y keys are swapped compared to American. And because Thunder Client assumes the American layout / uses hardcoded physical keys instead of inspecting the value of the keypress.

To Reproduce

  1. Set your keyboard layout to German in your OS settings
  2. Type something in a request URL bar
  3. Press Ctrl+Z relative to the German layout. E.g. if you have an American keyboard, use the physical Y key.
  4. No undo happens

Expected behavior
I expect Thunder Client to use the existing keyboard shortcuts for Undo / Redo set in VSCode. This would lead to my expected shortcuts to work: I have also set Ctrl+Y for Redo in VSCode, but Thunder Client uses Ctrl+Shift+Z, which becomes Ctrl+Shift+Y on a German keyboard.

Platform:

  • OS: Linux (Fedora 38)
  • vscode version: 1.84.4
  • extension version: v2.15.0

Are you using the free version/paid version/trial:
Free

@realansgar realansgar added the bug Something isn't working label Nov 8, 2023
@rangav
Copy link
Collaborator

rangav commented Nov 8, 2023

Thanks @realansgar for reporting the issue, Will fix it in the next update ASAP.

@rangav rangav added the Priority Implement this asap label Nov 8, 2023
@rangav
Copy link
Collaborator

rangav commented Nov 9, 2023

This bug is fixed now and published to the marketplace, please update to v2.15.3

https://github.com/rangav/thunder-client-support/releases/tag/v2.15.3

Please test and let me know your feedback.

@rangav rangav closed this as completed Nov 9, 2023
@rangav
Copy link
Collaborator

rangav commented Nov 9, 2023

For now the keys are Ctrl + Z or Y for undo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority Implement this asap
Projects
None yet
Development

No branches or pull requests

2 participants