Performance slow on macOS

[azplanlos]

Describe the bug
Performance of Thunder Client plugin within Visual Studio Code is very slow on macOS when a workspace with multiple collections with many folders and requests is open. Opening a request window takes up to 45-60 seconds while the whole client is unresponsive and multiple messages are presented by Visual Studio Code to inform about this unresponsibilty asking if the user wants to wait ore close the window. Meanwhile the request body of the request is already shown but existing variables are not highlighted in the correct color which changes after the window gets responsive again.

To Reproduce
Open a request

Expected behavior
should open quickly

Platform:

• OS: macOS 14.1 (Apple M2 Pro)
• vscode version: 1.83.0 (Universal)
• extension version: 2.15.0

Are you using the free version/paid version/trial:
paid version

[rangav]

Thanks @azplanlos reporting the bug, will look into it.

[rangav]

I am using an Apple M2 Pro laptop, does not have these issues.

One Clarification:

Does the issue happen with Request Views only?

Can you open evironment view - is it slow or good?

[azplanlos]

Environment view is good, also "RunAll" view opens quickly as expected, also browsing the collection is fine. Seems to be request view only.

[rangav]

Thanks for confirmation. I did notice that the Request view is slow sometimes, might be the Ace Editor library that I am using is not updated for Apple Silicon.

Will investigate the issue further and get back to you asap.

[rangav]

I will make couple of code changes for testing and file here for you to confirm which changes is fixing the issue.

Will you be available for quick testing?

[azplanlos]

Sure, just let me know

[rangav]

Can you please test the below version and let me know if you noticed any difference?

• Please install it manually

[azplanlos]

Yes, this is much better now, thank you!

[rangav]

Thats Good, Thanks for confirmation - do you notice any other performance issues?

[azplanlos]

no, overall performance is very good now.

[rangav]

Super, Thanks for confirmation.

The change I made is that in the body JSON editor - the env variable highlighting is disabled. Which is causing the issue I guess.

[rangav]

@azplanlos I have re-enabled JSON body editor highlighting, but made a few code optimization around this issue.

• Now I added a vscode setting to disable hightlighting

Can you please test with the above with setting enabled and disabled, and let me know the performance difference.

[rangav]

When you change setting value, please close request view and reopen

[azplanlos]

just testet your new version and it works fine regardless of the highlight setting.

[rangav]

Good Thanks, The changes I made to the code are working then. I will publish an update later today with these changes.

[rangav]

This bug is fixed now and published to the marketplace, please update to v2.15.3

https://github.com/rangav/thunder-client-support/releases/tag/v2.15.3

Please test and let me know your feedback.