Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probably mixture of using uint32 and int32 #122

Open
RobertFlame opened this issue Jul 2, 2022 · 0 comments
Open

Probably mixture of using uint32 and int32 #122

RobertFlame opened this issue Jul 2, 2022 · 0 comments

Comments

@RobertFlame
Copy link

Hi, recently I'm using your LINE algorithm implementation for my research project, and I noticed that I'm having some issues with the data type of uint32 and int32. In line.py, line31-32, the h, and t are of type tf.int32. However, in line137, the values in sampling_table are defined as np.uint32. I know that it's usually not that easy to make some overflow of numbers and I'm pretty sure I don't have any overflow issues, but in my case, it seems to have a similar effect. After I changed all of them to int64, everything works as expected. So I guess it would be better to adopt the same data type in these places. Does anyone know what's happening behind this? Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant