Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"@types/jest" had a breaking change in 23.3.14 #226

Closed
iRoyPeleg opened this issue Feb 7, 2019 · 3 comments
Closed

"@types/jest" had a breaking change in 23.3.14 #226

iRoyPeleg opened this issue Feb 7, 2019 · 3 comments

Comments

@iRoyPeleg
Copy link
Contributor

Hey,

So you currently have @types/jest under dependencies:

"dependencies": {
    "@types/jest": "^23.3.10",
    "ts-jest": "~23.10.5"
  },

Version 23.3.13 of @types/jest was compatible all the way down to TypeScript 2.2 I believe.
Version 23.3.14 requires at least TypeScript 2.8, which broke one of our apps build process.

First, do you need @types/jest under dependencies at all? can it be under devDepenedencies instead?

Second, we're currently aiming at ^23.3.10, maybe change it to 23.3.13 just so it won't break apps under TS 2.8?

Thanks.

@thymikee
Copy link
Owner

thymikee commented Feb 7, 2019

It should be a dev dep, happy to accept PR :)

@wtho
Copy link
Collaborator

wtho commented Feb 7, 2019

I think it was a conscious decision to put it in dependencies, but I'm not sure why.

2273e1f

cc @ahnpnl

@ahnpnl
Copy link
Collaborator

ahnpnl commented Feb 7, 2019

My idea at the point I put into dependencies was to make it easier when installing the preset. But no problem to put it in dev deps again👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants