Add return types to MimePart so it works on PHP 8 with the newer version of psr/http-message #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of psr/http-message that has return types which causes a Fatal Error on PHP 8; Add a MimePart::getBodyString() helper method that converts MimePart::getBody()'s StreamInterface into a string and update all the calling code for MimePart::getBody() over to MimePart::getBodyString()
|
@mattdinthehouse Thanks! Looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MimePartclass implementsPsr\Http\Message\MessageInterfaceviaguzzlehttp/guzzlewhich was recently updated with added return types that cause a "method is not compatible" type error inMimePartThis PR adds those return types to
MimePartso it'll work on PHP 8All the calling code expects
MimePart::getBody()to return a string but now it returns aStreamInterfaceso I've updated the calling code in this library to use a newMimePart::getBodyString()method - if downstream users depend on strings then use this newer method to get them