Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏ Fix link to FastAPI and Friends newsletter #13

Merged
merged 4 commits into from
Nov 4, 2022

Conversation

JonasKs
Copy link
Contributor

@JonasKs JonasKs commented Jan 9, 2022

Added newsletter.md, as it is in FastAPI.

Since uBlock origin causes the form not to load, I also added an information box:

bilde

Please note I haven't used mkdocs before, and this INFO message is printed when I serve them:

INFO     -  The following pages exist in the docs directory, but are not included in the "nav" configuration:
              - newsletter.md

Which seems fine by me, but thought I'd let you know if there is a way to silence this.


2022-11-04 Edit by @tiangolo: Update link to point to FastAPI and Friends newsletter.

@JonasKs
Copy link
Contributor Author

JonasKs commented Jan 9, 2022

https://github.com/tiangolo/asyncer/blob/main/CONTRIBUTING.md

This link also does not lead to anything.

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

📝 Docs preview for commit b4f305c at: https://636582d3502d870f8cbb3993--asyncer.netlify.app

@tiangolo tiangolo changed the title ✏️ Add newsletter.md, fixing broken link. ✏ Fix link to FastAPI and Friends newsletter Nov 4, 2022
@tiangolo tiangolo merged commit 09c2585 into fastapi:main Nov 4, 2022
@tiangolo
Copy link
Member

tiangolo commented Nov 4, 2022

Thanks @JonasKs! ☕

I updated it to point to the FastAPI and Friends newsletter page on the FastAPI docs. 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants