Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add missing dependency typing_extensions for Python < 3.10 #89

Merged
merged 3 commits into from
Jan 23, 2024
Merged

🐛 Add missing dependency typing_extensions for Python < 3.10 #89

merged 3 commits into from
Jan 23, 2024

Conversation

ZhymabekRoman
Copy link
Contributor

typing_extensions is required for Python > 3.10

@ZhymabekRoman
Copy link
Contributor Author

Hmmm, tests failed. Probably we need to increase minimal Python version to 3.8?

@ZhymabekRoman
Copy link
Contributor Author

@tiangolo

@tiangolo tiangolo changed the title Forgotten dependency install in Python < 3.10 🐛 Add missing dependency typing_extensions for Python < 3.10 Jan 23, 2024
Copy link

📝 Docs preview for commit e7e09de at: https://b3e0b313.asyncer.pages.dev

@tiangolo tiangolo added the bug Something isn't working label Jan 23, 2024
@tiangolo
Copy link
Member

Great, thank you @ZhymabekRoman! 🚀

@tiangolo tiangolo merged commit 429eb53 into fastapi:main Jan 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants