-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Open API prefix route - correct docs behind reverse proxy #26
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 95 99 +4
Lines 2484 2582 +98
=====================================
+ Hits 2484 2582 +98
Continue to review full report at Codecov.
|
Fix for #15 |
@tiangolo would you mind taking a look at this? |
Great job @kabirkhan ! Thanks a lot. 🎉 🌮 I added tests and docs on top of your work.
Are you using it at MS? That's very cool! |
I just released Also, the relevant docs are here: https://fastapi.tiangolo.com/tutorial/sub-applications-proxy/ |
@tiangolo yep I'm actually planning to use it for all of my team's ML services at Microsoft. Some of them are getting integrated into the core Windows product and some Office products. Great job with the documentation too! |
That's awesome! 🌮 🍰 🚀 May I quote it (that you at MS are using FastAPI)? |
Yeah, go for it! |
I know this is an old issue/PR, but shouldn't |
Huh, sounds about right. @sm-Fifteen you may open a new issue for that. |
Yeap @sm-Fifteen, I just merged #1199 addressing |
@tiangolo seems the link to the prefix route docs is broken. Perhaps did the docs move?
|
I run a lot of services in Kubernetes using Ambassador as my API Gateway. Ambassador allows you to configure a route prefix for each one of your services and then it handles ingress and routing to the initial service. This PR enables me to configure the same prefix I use with Ambassador in the Swagger UI API docs.
Example:
NOTE: This is not the same as using the include_router method and adding a prefix.
This is meant only to rewrite the route paths in the Swagger UI.
BTW: Awesome Project! Thanks so much for your work on this, I'm using fastapi a ton these days.