Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Optional added to docs for CLI Argument and Options #131

Merged
merged 3 commits into from
Aug 16, 2020

Conversation

rkbeatss
Copy link
Contributor

@rkbeatss rkbeatss commented Jul 1, 2020

Addressing #125 : all CLI arguments / options with default value of None declared using Optional generics

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #131 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #131   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          242       242           
  Lines         4504      4508    +4     
=========================================
+ Hits          4504      4508    +4     
Impacted Files Coverage Δ
...rc/multiple_values/multiple_options/tutorial001.py 100.00% <100.00%> (ø)
docs_src/options/version/tutorial003.py 100.00% <100.00%> (ø)
docs_src/parameter_types/bool/tutorial002.py 100.00% <100.00%> (ø)
docs_src/parameter_types/path/tutorial001.py 100.00% <100.00%> (ø)
docs_src/testing/app01/main.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2235d1...c2fb81e. Read the comment docs.

Copy link

@zhezhel zhezhel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiangolo tiangolo merged commit 32436f0 into fastapi:master Aug 16, 2020
@tiangolo
Copy link
Member

Awesome! Thank you @rkbeatss ! 🚀 🍰 🎉

And thanks @zhezhel for the review ☕

@rkbeatss rkbeatss deleted the OptionalDocs branch August 18, 2020 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants