✨ Add support for mypy --strict #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 242 242
Lines 4504 4508 +4
=========================================
+ Hits 4504 4508 +4
Continue to review full report at Codecov.
|
tiangolo
changed the title
|
Thanks @victorphoenix3 ! 🎉 I went ahead and added a bunch of extra types to enable |
This was referenced Aug 16, 2020
| @@ -1,40 +1,37 @@ | |||
| """Typer, build great CLIs. Easy to code. Based on Python type hints.""" | |||
|
|
|||
| __version__ = "0.3.1" | |||
| from click.exceptions import Abort as Abort | |||
There was a problem hiding this comment.
Why from foo import bar as bar structure is preferred.
There was a problem hiding this comment.
That "re-exports" bar and let's tooling know that (instead of being overly t imported to be used internally).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/related to #142