Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add support for Click 8 while keeping compatibility with Click 7 #317

Merged
merged 13 commits into from
Aug 30, 2021

Conversation

tiangolo
Copy link
Member

✨ Add support for Click 8 while keeping support for Click 7

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #317 (88075b0) into master (c3a4c72) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #317    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          242       252    +10     
  Lines         4508      5287   +779     
==========================================
+ Hits          4508      5287   +779     
Impacted Files Coverage Δ
..._parameter_types/test_datetime/test_tutorial001.py 100.00% <ø> (ø)
...test_parameter_types/test_enum/test_tutorial001.py 100.00% <ø> (ø)
...est_parameter_types/test_index/test_tutorial001.py 100.00% <ø> (ø)
...st_parameter_types/test_number/test_tutorial001.py 100.00% <ø> (ø)
...st_parameter_types/test_number/test_tutorial002.py 100.00% <ø> (ø)
...test_parameter_types/test_uuid/test_tutorial001.py 100.00% <ø> (ø)
tests/assets/compat_click7_8.py 100.00% <100.00%> (ø)
tests/test_compat/test_option_get_help.py 100.00% <100.00%> (ø)
tests/test_completion/test_completion.py 100.00% <100.00%> (ø)
tests/test_completion/test_completion_install.py 100.00% <100.00%> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3a4c72...88075b0. Read the comment docs.

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@tiangolo tiangolo changed the title ✨ Add support for Click 8 while keeping support for Click 7 ✨ Add support for Click 8 while keeping compatibility with Click 7 Aug 30, 2021
@tiangolo tiangolo merged commit b972981 into master Aug 30, 2021
@tiangolo tiangolo deleted the click-8 branch August 30, 2021 07:57
This was referenced Aug 30, 2021
@mdantonio mdantonio mentioned this pull request Feb 28, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant