Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Fix header format for "Standard Input" in docs/tutorial/printing.md #386

Merged
merged 2 commits into from
May 12, 2022
Merged

🎨 Fix header format for "Standard Input" in docs/tutorial/printing.md #386

merged 2 commits into from
May 12, 2022

Conversation

briancohan
Copy link
Contributor

Based on the TOC and contents of the file, "Standard Input" does not appear to belong as a sub-item of "Standard Output" and "Standard Error". Header was changed from h3 ### to h2 ##.

Based on the TOC of the file, `"Standard Input"` does not appear to belong as a sub-item of `"Standard Output" and "Standard Error"`. Header was changed from h3 `###` to h2 `##`.
@svlandeg svlandeg added the docs Improvements or additions to documentation label Apr 21, 2022
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, "Standard Input" and "Standard output" should be at the same level :-)

Thanks for the PR!

@tiangolo tiangolo changed the title Changed heading level for Standard Input 🎨 Fix header format for "Standard Input" in docs/tutorial/printing.md May 12, 2022
@tiangolo
Copy link
Member

Ah! Nice catch! That wasn't an obvious one. 🤓 Thanks @briancohan! 🍰

And thank you @svlandeg! 🍪 ☕

@tiangolo tiangolo enabled auto-merge (squash) May 12, 2022 19:13
@github-actions
Copy link

📝 Docs preview for commit 86da27f at: https://627d5c5c52cb9c17e4589d4b--typertiangolo.netlify.app

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #386 (86da27f) into master (dc26b21) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #386   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          252       252           
  Lines         5287      5287           
=========================================
  Hits          5287      5287           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc26b21...86da27f. Read the comment docs.

@tiangolo tiangolo merged commit 7f65b64 into fastapi:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants