Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏️ Add quotes to package name that includes brackets in docs #475

Merged
merged 2 commits into from
Nov 6, 2022

Conversation

gjolga
Copy link
Contributor

@gjolga gjolga commented Nov 4, 2022

From poetry's docs:

Some shells may treat square braces ([ and ]) as special characters. It is suggested to always quote arguments containing these characters to prevent unexpected shell expansion.
https://python-poetry.org/docs/cli/#add

@tiangolo tiangolo changed the title Adds quotes to package name that includes brackets ✏️ Add quotes to package name that includes brackets in docs Nov 6, 2022
@tiangolo
Copy link
Member

tiangolo commented Nov 6, 2022

Great, thanks @gjolga! 🍰

@tiangolo tiangolo enabled auto-merge (squash) November 6, 2022 15:09
@github-actions
Copy link

github-actions bot commented Nov 6, 2022

📝 Docs preview for commit 9c1c763 at: https://6367ce41018cc1597b53b6df--typertiangolo.netlify.app

@tiangolo tiangolo merged commit 9f2d7eb into fastapi:master Nov 6, 2022
alexreg pushed a commit to alexreg/typer-cloup that referenced this pull request Nov 11, 2022
…#475)

Adds quotes to package name with brackets

Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
alexreg pushed a commit to alexreg/typer-cloup that referenced this pull request Nov 15, 2022
…#475)

Adds quotes to package name with brackets

Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants