Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix evaluating stringified annotations in Python 3.10 (also from __future__ import annotations) #721

Merged
merged 4 commits into from
Mar 23, 2024
Merged

🐛 Fix evaluating stringified annotations in Python 3.10 (also from __future__ import annotations) #721

merged 4 commits into from
Mar 23, 2024

Conversation

heckad
Copy link
Contributor

@heckad heckad commented Dec 19, 2023

Fix case when annotated type inside string or from __future__ import annotations used.

@heckad heckad force-pushed the fix/allow-to-be-annotated-in-string branch from 928cca6 to 665786e Compare December 19, 2023 09:17
@heckad heckad force-pushed the fix/allow-to-be-annotated-in-string branch from 5a8b415 to f133a9e Compare December 19, 2023 09:19
svlandeg
svlandeg reviewed Feb 28, 2024
View reviewed changes
Copy link
Member

@svlandeg svlandeg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me, and the PR is related to earlier discussions #684 and #598.

I could replicate the issue with Python 3.10 and the fix from this PR indeed seems to resolve it.

@svlandeg svlandeg added bug Something isn't working p2 labels Feb 28, 2024
@tiangolo tiangolo changed the title Add eval_str to inspect.signature 🐛 Fix evaluating stringified annotations in Python 3.10 (also from __future__ import annotations) Mar 23, 2024
@tiangolo
Copy link
Member

Awesome, thanks @heckad! 🚀

And thank you @svlandeg for the help! 🙇

This will be available in Typer 0.9.3, released in the next few hours. 🚀

@tiangolo tiangolo merged commit d1a177c into fastapi:master Mar 23, 2024
18 checks passed
@chaen chaen mentioned this pull request Mar 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg left review comments

Assignees
No one assigned
Labels
bug Something isn't working p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heckad @tiangolo @svlandeg