Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestions in TSS including " and/or ' characters #152

Closed
Frk7 opened this issue Apr 9, 2019 · 0 comments · Fixed by #154
Closed

Suggestions in TSS including " and/or ' characters #152

Frk7 opened this issue Apr 9, 2019 · 0 comments · Fixed by #154

Comments

@Frk7
Copy link

Frk7 commented Apr 9, 2019

Summary

It wuold be nice if suggestions for e.g. layout or color properties in TSS included " or '. So we could omit typing quotes.
Now selecting vertical suggestion for layout property autocompletes to vertical, it would be nice to have "vertical" instead.

Obviously suggestions must be shown typing both vert and "vert.

For example yomybaby/atom-titanium includes quotes in suggestions (and autocompletes with them):

layout sugg

color sugg

Your Environment

| macOS | 10.14.3 |
| Atom | 1.35.1 |
| Titanium Atom Package | 1.6.0 |
longton95 added a commit to longton95/atom-appcelerator-titanium that referenced this issue May 7, 2019
@longton95
fix(styleprovider): improved suggestions to include quotes
54342f4 
Fixes tidev#152
@longton95 longton95 mentioned this issue May 7, 2019
Merged
ewanharris pushed a commit that referenced this issue May 8, 2019
@longton95 @ewanharris
fix(styleprovider): improved suggestions to include quotes for color …
37f378f 
…and layout properties (#154)

* fix(styleprovider): improved suggestions to include quotes

Fixes #152

* test(styleprovider): added tests

* ci: tie to a jenkins node with atom installed
longton95 added a commit that referenced this issue May 8, 2019
@longton95
fix(styleprovider): improved suggestions to include quotes for color …
f7128a8 
…and layout properties (#154)

* fix(styleprovider): improved suggestions to include quotes

Fixes #152

* test(styleprovider): added tests

* ci: tie to a jenkins node with atom installed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Frk7