Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable instead of rowname #117

Closed
bjornerstedt opened this issue Oct 19, 2020 · 3 comments · Fixed by #123
Closed

variable instead of rowname #117

bjornerstedt opened this issue Oct 19, 2020 · 3 comments · Fixed by #123
Labels
feature a feature request or enhancement

Comments

@bjornerstedt
Copy link

Feature

The correlate functions generates a tibble with "rowname" as the first column. It should be called "variable" (or something similar) instead, to better match the the column content and to avoid having to rename the column when used in printed output.

@juliasilge
Copy link
Member

This is... a great point. We've decided that our preferred name for the first column is term, like the output from broom::tidy().

It is possible that this change will break folks' existing code, so our plan from here is to start out by keeping the column name the same and generating a soft deprecation warning that the name will change in the future. Then, in another release, we'll change the column name, still with a warning.

@juliasilge juliasilge added the feature a feature request or enhancement label Oct 19, 2020
@bjornerstedt
Copy link
Author

Calling it term is better, I agree.

@github-actions
Copy link

github-actions bot commented Mar 6, 2021

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants