Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS Review] Random seeds for reproducibility #416

Closed
kellieotto opened this issue Sep 6, 2021 · 1 comment · Fixed by #417
Closed

[JOSS Review] Random seeds for reproducibility #416

kellieotto opened this issue Sep 6, 2021 · 1 comment · Fixed by #417

Comments

@kellieotto
Copy link

This comment is part of your JOSS Review.

I see that there are random seeds set in the unit tests and it is mentioned in the GitHub issue prompt, but the importance of setting the random seed isn't mentioned in the documentation for the package. I think this is a crucial piece of documentation/information that is missing, especially since this a goal of this package is to be used for statistics pedagogy. As is, the user will get different results each time they run the code if they do not first set the seed.

Apart from including set.seed in all of the examples, you may want to consider how you could build it into the package, as a function argument or something that's stated in a series of functions.

@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant