You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I see that there are random seeds set in the unit tests and it is mentioned in the GitHub issue prompt, but the importance of setting the random seed isn't mentioned in the documentation for the package. I think this is a crucial piece of documentation/information that is missing, especially since this a goal of this package is to be used for statistics pedagogy. As is, the user will get different results each time they run the code if they do not first set the seed.
Apart from including set.seed in all of the examples, you may want to consider how you could build it into the package, as a function argument or something that's stated in a series of functions.
The text was updated successfully, but these errors were encountered:
This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.
This comment is part of your JOSS Review.
I see that there are random seeds set in the unit tests and it is mentioned in the GitHub issue prompt, but the importance of setting the random seed isn't mentioned in the documentation for the package. I think this is a crucial piece of documentation/information that is missing, especially since this a goal of this package is to be used for statistics pedagogy. As is, the user will get different results each time they run the code if they do not first set the seed.
Apart from including set.seed in all of the examples, you may want to consider how you could build it into the package, as a function argument or something that's stated in a series of functions.
The text was updated successfully, but these errors were encountered: