Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snap changes with additional warning context on R-devel #530

Closed
simonpcouch opened this issue Mar 25, 2024 · 4 comments · Fixed by #531
Closed

snap changes with additional warning context on R-devel #530

simonpcouch opened this issue Mar 25, 2024 · 4 comments · Fixed by #531
Labels
upkeep maintenance, infrastructure, and similar

Comments

@simonpcouch
Copy link
Collaborator

On main dev version, a number of snap changes in GHA where the header for warnings includes context. Only occurs on R-devel:

-   Warning:
+   Warning in `p_value()`:
@simonpcouch

This comment was marked as resolved.

Sign in to view
@simonpcouch

This comment was marked as resolved.

Sign in to view
@simonpcouch
Copy link
Collaborator Author

Due to changes in base R .Deprecated(). Transitioning to lifecycle so that we get version-stable results. Advancing conf_int() and p_value() deprecations to deprecate_stop(), as these have been deprecated since #181.

@simonpcouch simonpcouch mentioned this issue Mar 25, 2024
Merged
@simonpcouch simonpcouch added the upkeep maintenance, infrastructure, and similar label Mar 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

transition to lifecycle for deprecations tidymodels/infer
1 participant
@simonpcouch