Bias corrected confidence interval

[davidbaniadam]

Hello,
Thanks for your package.
I have included a bias corrected confidence interval in get_confidence_interval.
I have used the formulas on this page: https://www.jmp.com/support/help/14-2/bias-corrected-percentile-intervals.shtml

I hope it can get implemented.
Thanks
David

[codecov-io]

Codecov Report

Merging #237 into develop will decrease coverage by 0.76%.
The diff coverage is 40%.

@@             Coverage Diff             @@
##           develop     #237      +/-   ##
===========================================
- Coverage      100%   99.23%   -0.77%     
===========================================
  Files           15       15              
  Lines         1163     1173      +10     
===========================================
+ Hits          1163     1164       +1     
- Misses           0        9       +9

Impacted Files	Coverage Δ
R/generate.R	100% <ø> (ø)	⬆️
R/visualize.R	100% <100%> (ø)	⬆️
R/get_confidence_interval.R	77.5% <30.76%> (-22.5%)	⬇️

[andrewpbray]

Hi David,
Thanks very much for the PR - these type of extensions are great to see. I'm currently traveling but I'll have a look at this next week.

[davidbaniadam]

Hi Andrew,
Thanks! I look forward to hear from you.
David

[echasnovski]

Hello, @davidbaniadam!

Sorry for such a huge delay. Are you still interested in this PR? It needs some git "sorcery", test and documentation updates. Functionality seems useful, so I am happy to help here.

[davidbaniadam]

Hi @echasnovski I don't understand what I should do?

[echasnovski]

There are at least two choices here:

• We work together on making this PR ready to merge. This includes:
  • Synchronize this git branch with current 'develop' branch.
  • Update 'testthat' tests to reflect newly added functionality.
  • Update 'roxygen2' documentation with description of this new option.
• I take this code from here and make all necessary changes myself, while including you as original author of suggestion.

[davidbaniadam]

@echasnovski If you could finish it it would be great.

[echasnovski]

Sure, no problem. Hope, this will take less than a year :)

@andrewpbray, @ismayc, @simonpcouch: do you agree that this update (combined with future #311) will be useful?

[ismayc]

Makes sense to me. Thanks for your patience, @davidbaniadam.

[simonpcouch]

Agreed!

[echasnovski]

Great! I'll try to make this during next couple of weeks.

[echasnovski]

This functionality is now implemented in #318. I couldn't work locally with this PR, so started a new one.

Thank you once again @davidbaniadam for suggesting this method and for initial implementation.

[github-actions]

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.