Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the documentation in #47 #53

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

guslipkin
Copy link

@guslipkin guslipkin commented Oct 19, 2022

This does not fix the underlying download functions in data-raw.

All links are now up to date, along with download functions in data-raw and the data itself.

@guslipkin
Copy link
Author

I also updated nycflights. At this point, I think I'd like to take over both of them to the best of my ability and try and synchronize the code and modernize it while keeping backwards compatibility with old versions of R.

I mentioned this in my commit to nycflights as well, but I'm not really sure what the process for that would be besides just making lots of PRs

There was something keeping me up with the other commit. Row counts didn't match.

I did my best but the current data is too different to the original and I don't have access to the original source files. In the new version, there are four tail numbers that no longer exist in `planes`.  However, there are now 38 more tail numbers in `planes` and 1213 more `flights` that have a tail number with an associated plane.
@jabenninghoff
Copy link

FYI, the old AR062014.zip file is still available on archive.org:

https://web.archive.org/web/20140707054650/http://registry.faa.gov/database/AR062014.zip

I haven't done any comparison against the new ReleasableAircraft file yet, but having the old file should help resolve any questions about how to parse the new format.

jabenninghoff added a commit to jabenninghoff/mspflights that referenced this pull request Mar 16, 2024
jabenninghoff added a commit to jabenninghoff/mspflights that referenced this pull request Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants