Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve response writer safety #30

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Conversation

tigerwill90
Copy link
Owner

@tigerwill90 tigerwill90 commented Feb 26, 2024

goos: linux
goarch: amd64
pkg: github.com/tigerwill90/fox
cpu: Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz
                    │   old.txt    │               new.txt               │
                    │    sec/op    │    sec/op     vs base               │
StaticAll-16          11.25µ ±  0%   11.12µ ±  1%  -1.14% (p=0.001 n=10)
GithubParamsAll-16    81.85n ±  1%   81.91n ±  1%       ~ (p=0.756 n=10)
OverlappingRoute-16   95.47n ±  1%   98.48n ±  1%  +3.15% (p=0.000 n=10)
StaticParallel-16     10.31n ±  5%   10.43n ±  3%       ~ (p=0.955 n=10)
CatchAll-16           31.40n ±  1%   30.33n ±  5%       ~ (p=0.093 n=10)
CatchAllParallel-16   5.661n ± 17%   5.630n ± 27%       ~ (p=0.280 n=10)
CloneWith-16          69.57n ±  2%   64.94n ±  1%  -6.65% (p=0.000 n=10)
geomean               73.16n         72.35n        -1.10%

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 52.77778% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 87.89%. Comparing base (6b8d3ab) to head (7720509).

Files Patch % Lines
response_writer.go 50.00% 14 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   86.84%   87.89%   +1.04%     
==========================================
  Files          12       12              
  Lines        1657     1660       +3     
==========================================
+ Hits         1439     1459      +20     
+ Misses        187      170      -17     
  Partials       31       31              
Flag Coverage Δ
coverage.txt 87.89% <52.77%> (+1.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tigerwill90 tigerwill90 marked this pull request as ready for review February 27, 2024 21:07
@tigerwill90 tigerwill90 merged commit 85d87fe into master Feb 27, 2024
7 of 8 checks passed
@tigerwill90 tigerwill90 deleted the feat/improved-response-writer branch February 27, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant