-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default logger middleware #33
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # options.go
…ntext package to netcontext
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #33 +/- ##
==========================================
- Coverage 88.08% 87.38% -0.70%
==========================================
Files 12 15 +3
Lines 1678 1911 +233
==========================================
+ Hits 1478 1670 +192
- Misses 169 189 +20
- Partials 31 52 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a default middleware for logging incoming requests, responses status, and other relevant information. The middleware is compatible with the new
slog.Logger
and allow to use any handler that implementslog.Handler
.It feature also preliminary work for "real" client IP derivation. The
WithClientIPStrategy
option allows you to set up strategies to derive the client IP address based on your use case and network topology. A sets of builtin strategy are available in the sub-packagegit.luolix.top/tigerwill90/fox/strategy
. Any strategy that implementClientIPStrategy
can be integrated to fox.And now
Context.ClientIP
will derive the ip using the "rightmost non private" strategy.Small optimisation have been achieved on the
Context
allocation.