Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PD to github.com/tikv/pd #2758

Closed
6 tasks done
nolouch opened this issue Aug 12, 2020 · 3 comments
Closed
6 tasks done

Move PD to github.com/tikv/pd #2758

nolouch opened this issue Aug 12, 2020 · 3 comments
Assignees
Labels
priority/P0 The issue has P0 priority. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/discussion-wanted The issue needs to be discussed.

Comments

@nolouch
Copy link
Contributor

nolouch commented Aug 12, 2020

We are going to move PD to TiKV GitHub organization.
Our motivation is TiKV has a strong dependency on PD, they together form a distributed KV system.

Filing an issue to sort through what needs to be done:

  • Announce to TiDB/TiKV communities. (11 AM, UTC+8, August 17, 2020)
  • Transfer ownership
  • Update all internal github.com/pingcap/pd import paths in all branches
  • Set up new CIs, Bots in New Org
  • Reconfigure automated testing: Travis, Jenkins, Circle...
  • Update the import paths and go.mod of all downstream dependent projects in pingcap

Some relative issues:

  • Can all the released TiDB versions still compile successfully?
    Yes. github will redirect all requests to the new URL and go mod download still works.
  • Consider canceling the semantic Import mechanism in PD
    Because we meet some problems like: Will cause cherry-pick to conflict with the lower version branch of a release, Weird dependency problems like pd and pd/v4 appeared at the same time in one repo, Need to resolve lots of dependency problem after we bump to a higher version
@nolouch nolouch added type/enhancement The issue or PR belongs to an enhancement. priority/P0 The issue has P0 priority. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/discussion-wanted The issue needs to be discussed. and removed type/enhancement The issue or PR belongs to an enhancement. labels Aug 12, 2020
@nolouch nolouch self-assigned this Aug 12, 2020
@HunDunDM
Copy link
Member

If we want to use vanity imports, we may need https://github.com/GoogleCloudPlatform/govanityurls.

@disksing
Copy link
Contributor

disksing commented Sep 7, 2020

Can we close it now?

@nolouch
Copy link
Contributor Author

nolouch commented Sep 10, 2020

yes

@nolouch nolouch closed this as completed Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/P0 The issue has P0 priority. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/discussion-wanted The issue needs to be discussed.
Projects
None yet
Development

No branches or pull requests

3 participants