Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new-hotspot-scheduler] add operator influence and more metrics #1713

Merged
merged 61 commits into from
Sep 9, 2019

Conversation

Luffbee
Copy link
Contributor

@Luffbee Luffbee commented Aug 28, 2019

changes:

  • disabled balance hot write by leader.
  • add operator influence:
    • pending influence before operator finish
    • zombie influence after operator finish
  • more metrics to track hotspot operators

rleungx and others added 30 commits August 19, 2019 15:41
Signed-off-by: Ryan Leung <rleungx@gmail.com>
* test: fix region syncer test

Signed-off-by: disksing <i@disksing.com>
Signed-off-by: cwen0 <cwenyin0@gmail.com>
This reverts commit e74c7a9.
Luffbee and others added 12 commits August 22, 2019 21:39
Signed-off-by: Ryan Leung <rleungx@gmail.com>
…#1659)

* schedule: Do not send an operator of a region wth a stale epoch

Signed-off-by: Shafreeck Sea <shafreeck@gmail.com>

* schedule: check the version changed by the operator self

Signed-off-by: Shafreeck Sea <shafreeck@gmail.com>

* schedule: fix unit test

Signed-off-by: Shafreeck Sea <shafreeck@gmail.com>

* schedule: fix to avoid dispatching a stale opstep

Signed-off-by: Shafreeck Sea <shafreeck@gmail.com>

* dispatch: refactor "ConsumeConfVer() int" to "ExpectConfVerChange() bool"

Signed-off-by: Shafreeck Sea <shafreeck@gmail.com>

* dispatch: fix typo in comment

Signed-off-by: Shafreeck Sea <shafreeck@gmail.com>

* fix typo

Co-Authored-By: Ryan Leung <rleungx@gmail.com>

* dispatch: fix unittest

Signed-off-by: Shafreeck Sea <shafreeck@gmail.com>

* dispatch: refine format

Signed-off-by: Shafreeck Sea <shafreeck@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@codecov-io
Copy link

codecov-io commented Aug 28, 2019

Codecov Report

Merging #1713 into new-hotspot-scheduler will decrease coverage by 0.03%.
The diff coverage is 61.26%.

Impacted file tree graph

@@                    Coverage Diff                    @@
##           new-hotspot-scheduler    #1713      +/-   ##
=========================================================
- Coverage                  75.71%   75.67%   -0.04%     
=========================================================
  Files                        158      161       +3     
  Lines                      15941    16262     +321     
=========================================================
+ Hits                       12070    12307     +237     
- Misses                      2837     2923      +86     
+ Partials                    1034     1032       -2
Impacted Files Coverage Δ
server/statistics/region.go 96% <ø> (ø) ⬆️
pkg/cache/cache.go 0% <ø> (ø) ⬆️
server/statistics/hot_cache.go 61.3% <ø> (ø) ⬆️
...ools/pd-simulator/simulator/simutil/case_config.go 0% <0%> (ø)
server/schedulers/metrics.go 100% <100%> (ø) ⬆️
tools/pd-ctl/pdctl/command/config_command.go 73.54% <100%> (+2.24%) ⬆️
server/cluster.go 84.16% <100%> (+1.31%) ⬆️
tools/pd-ctl/pdctl/ctl.go 94.87% <100%> (+10.66%) ⬆️
server/region_syncer/server.go 82.05% <100%> (+0.15%) ⬆️
client/client.go 69.76% <100%> (+3.98%) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c4fd92...add662c. Read the comment docs.

@nolouch nolouch added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2019
@Luffbee Luffbee merged commit 83ab4c2 into tikv:new-hotspot-scheduler Sep 9, 2019
@Luffbee Luffbee deleted the new-hotspot-scheduler branch September 9, 2019 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants