-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add Makefile for msc #5856
*: add Makefile for msc #5856
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov ReportBase: 74.91% // Head: 75.63% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5856 +/- ##
==========================================
+ Coverage 74.91% 75.63% +0.72%
==========================================
Files 335 337 +2
Lines 34094 34137 +43
==========================================
+ Hits 25540 25819 +279
+ Misses 6359 6101 -258
- Partials 2195 2217 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest lgtm
@@ -46,6 +46,3 @@ enable-codegen: | |||
disable-codegen: | |||
cd ../../ && $(MAKE) failpoint-disable | |||
go mod tidy | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use it.
I'm going to merge this PR. I have no idea why there are two approve but only get one LGTM label. |
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: fb48c14
|
Signed-off-by: Ryan Leung <rleungx@gmail.com>
/merge |
@rleungx: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: a384bd4
|
Signed-off-by: Ryan Leung rleungx@gmail.com
What problem does this PR solve?
Issue Number: Ref #5851.
What is changed and how does it work?
Let
make check
work formsc
.Check List
Tests
Release note