Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A full benchmarking suite #109

Open
Hoverbear opened this issue Aug 27, 2018 · 6 comments
Open

A full benchmarking suite #109

Hoverbear opened this issue Aug 27, 2018 · 6 comments
Labels
Good First Issue A good issue for a new contributor. Help Wanted An issue with unsolved problems, looking for help. Tooling/Testing CI, benchmarking, and testing infrastucture.

Comments

@Hoverbear
Copy link
Contributor

It'd be great to have a full, robust benchmarking suite.

I recommend using Criterion for benchmarking since we can use it fairly unobtrusively, even on stable.
@Hoverbear Hoverbear added Help Wanted An issue with unsolved problems, looking for help. Good First Issue A good issue for a new contributor. labels Aug 27, 2018
@Hoverbear Hoverbear mentioned this issue Aug 27, 2018
Merged
@Hoverbear Hoverbear added the Tooling/Testing CI, benchmarking, and testing infrastucture. label Sep 7, 2018
@Hoverbear
Copy link
Contributor Author

The bones are in place for this if anyone would like to build on it. Feel free to ping us here and we can give you some guidance!

@Hoverbear Hoverbear mentioned this issue Sep 21, 2018
Merged
@ckousik
Copy link

ckousik commented Jan 3, 2019

@Hoverbear I'd like to work on this

@Hoverbear
Copy link
Contributor Author

@ckousik I'd be really honoured. :) Is there anything I can help you with? You can examine our current benchmarking code and learn about Criterion to start.

@Hoverbear Hoverbear pinned this issue Feb 14, 2019
@Hoverbear
Copy link
Contributor Author

Hi @ckousik, any way I can help with this?

@Fullstop000
Copy link
Member

Fullstop000 commented Sep 6, 2019 •
edited
Loading

@Hoverbear Can I try to implement a simple benchmark case for raw node proposing like https://github.com/etcd-io/etcd/blob/master/raft/node_bench_test.go ? This could be useful in a lot of situations.

@Hoverbear
Copy link
Contributor Author

@Fullstop000 Please!? 😍

@Fullstop000 Fullstop000 mentioned this issue Sep 25, 2019
Merged
@Fullstop000 Fullstop000 mentioned this issue Nov 1, 2019
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue A good issue for a new contributor. Help Wanted An issue with unsolved problems, looking for help. Tooling/Testing CI, benchmarking, and testing infrastucture.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Hoverbear @Fullstop000 @ckousik