fix: fix clippy #553
Merged
fix: fix clippy #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dat Tien Nguyen <phongtomfapp@gmail.com>
Signed-off-by: Dat Tien Nguyen <phongtomfapp@gmail.com>
|
it's known issue: rust-lang/rust-clippy#13185 |
Signed-off-by: Dat Tien Nguyen <phongtomfapp@gmail.com>
Signed-off-by: Dat Tien Nguyen <phongtomfapp@gmail.com>
Signed-off-by: Dat Tien Nguyen <phongtomfapp@gmail.com>
BusyJay
reviewed
Oct 16, 2024
src/lib.rs
Outdated
| @@ -469,7 +469,7 @@ node.propose_conf_change(vec![], cc).unwrap(); | |||
| This process is a two-phase process, during the midst of it the peer group's leader is managing | |||
| **two independent, possibly overlapping peer sets**. | |||
|
|
|||
| > **Note:** In order to maintain resiliency guarantees (progress while a majority of both peer sets is | |||
| \> **Note:** In order to maintain resiliency guarantees (progress while a majority of both peer sets is | |||
datadriven/src/test_data_reader.rs
Outdated
| @@ -205,6 +205,7 @@ impl<'a> TestDataReader<'a> { | |||
| } | |||
| } | |||
|
|
|||
| #[allow(clippy::manual_inspect)] | |||
| pub fn emit(&mut self, str: &str) { | |||
| self.rewrite_buffer.as_mut().map(|rb| { | |||
There was a problem hiding this comment.
How about changing it with if let Some(rb) = &mut self.rewrite_buffer?
src/lib.rs
Outdated
| @@ -571,6 +571,7 @@ pub mod prelude { | |||
| /// | |||
| /// Currently, this is a `log` adaptor behind a `Once` to ensure there is no clobbering. | |||
| #[cfg(any(test, feature = "default-logger"))] | |||
| #[allow(static_mut_refs)] | |||
There was a problem hiding this comment.
How about using OnceLock to replace both LOGGER_INITIALIZED and LOGGER? static_mut_refs may be a hard error in the future.
There was a problem hiding this comment.
ok, I have updated the PR.
Signed-off-by: Dat Tien Nguyen <phongtomfapp@gmail.com>
BusyJay
approved these changes
Oct 20, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comment fix-ci