*: improve build process and update rocksdb #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huachaohuang
requested review from
breezewish,
DorianZheng and
zhangjinpeng87
breezewish
previously approved these changes
Nov 28, 2018
|
Have you use the related cargo-fmt to format the code? |
Some trivial changes are applied: - Refactor Makefile - Refactor README.md - Add the rust-toolchain - Update RocksDB submodule - Reorganize the tests structure
huachaohuang
dismissed stale reviews from breezewish and zhangjinpeng87
via
a5d6ddc
|
@zhangjinpeng1987 Yes, otherwise the CI will not pass :) |
breezewish
approved these changes
Nov 29, 2018
Closed
DorianZheng
added a commit
that referenced
this pull request
Jan 10, 2019
* *: update ci and format (#248) (cherry picked from commit dd413e4) * *: improve build process and update rocksdb (#243) Some trivial changes are applied: - Refactor Makefile - Refactor README.md - Add the rust-toolchain - Update RocksDB submodule - Reorganize the tests structure (cherry picked from commit 064ab22) * make format * allow nightly version fail * minor fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some trivial changes are applied: