Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipped conversion to eV? #3

Open
blokhin opened this issue Oct 10, 2019 · 3 comments
Open

Skipped conversion to eV? #3

blokhin opened this issue Oct 10, 2019 · 3 comments

Comments

@blokhin
Copy link
Member

blokhin commented Oct 10, 2019

# dealing with Fermi energies
state_dict['e_fermi'] = float(self.patterns['e_fermi'].search(self.data).groups()[0])
state_dict['e_fermi_units'] = 'Ha'

* Hartree ?

@blokhin
Copy link
Member Author

blokhin commented Oct 10, 2019

@ansobolev

@ansobolev
Copy link
Member

That's a parser, not a converter :)

@blokhin
Copy link
Member Author

blokhin commented Oct 11, 2019

Several reasons: eV is a standard, no need to store units, conversion is already done in other places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants