You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My recent work on the gate and wire models introduced some additional methods, some of them are meant to be used from outside of the library (part of the API) while others are just internal helper functions. To distinguish them easier, I would propose to follow naming conventions and rename internal methods to start with the prefix _.
Also, from an esthetic point of view, I would propose to unify method declaration syntax used throughout this project and decide whether to use name: function(argument) {} or name(argument) {}. I don't know if there is a "better" way to declare methods, but I think it would make sense to stick to one of them.
If you were okay with these changes, I would be happy to realize them.
The text was updated successfully, but these errors were encountered:
I'm all for clearly marking internals, and using an underscore prefix is a popular convention. I think it's worthwhile to do it, and this feels like a prerequisite before 1.0.0 release (I'm still using 0. release numbers, as I feel the API is still in flux and it would be a PITA to use semver.)
On declaration syntax, I prefer the "new" syntax (without the "function" keyword), as it's less typing and closer to how you write in e.g. TypeScript. (By the way, core DigitalJS is pure JS instead of TypeScript because of how Backbone works poorly with it.)
My recent work on the gate and wire models introduced some additional methods, some of them are meant to be used from outside of the library (part of the API) while others are just internal helper functions. To distinguish them easier, I would propose to follow naming conventions and rename internal methods to start with the prefix
_
.Also, from an esthetic point of view, I would propose to unify method declaration syntax used throughout this project and decide whether to use
name: function(argument) {}
orname(argument) {}
. I don't know if there is a "better" way to declare methods, but I think it would make sense to stick to one of them.If you were okay with these changes, I would be happy to realize them.
The text was updated successfully, but these errors were encountered: