Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server-side apply to kubectl #5277

Open
Raboo opened this issue Dec 13, 2021 · 3 comments
Open

Add server-side apply to kubectl #5277

Raboo opened this issue Dec 13, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@Raboo
Copy link

Raboo commented Dec 13, 2021

Describe the Feature You Want

Add optional support for server-side apply for k8s_yaml();
https://kubernetes.io/docs/reference/using-api/server-side-apply/

Current Behavior

Currently k8s_yaml(); only supports client-side apply.

Why Do You Want This?

Some some large yaml objects are impossible to apply using client-side apply.
Also it might be good for tilt to support server-side apply before it becomes default. They plan on making it the default.

Additional context
kubernetes/kubectl#712
banzaicloud/koperator#716

@Raboo Raboo added the enhancement New feature or request label Dec 13, 2021
@nicks
Copy link
Member

nicks commented Dec 13, 2021

Minor correction - k8s_yaml supports several different protocols for sending resources to the cluster, including a modified apply, a replace, and a delete+create, depending on what protocol makes the most sense. e.g., for large yaml objects it will usually use replace. cf #5065

(though agree that we should also add the ability to do server-side apply when the cluster supports it)

@Raboo
Copy link
Author

Raboo commented Dec 13, 2021

Hmm, maybe I was running to old version of tilt? In which version was this create/replace made for large yaml objects?

And yes, I think server-side apply should be an option still.

@nicks
Copy link
Member

nicks commented Dec 13, 2021

if you're using v0.23, it should use the replace strategy for large objects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants