Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for Updates button throws an error on unsupported platforms #317

Open
DinCahill opened this issue Feb 21, 2022 · 0 comments
Open

Check for Updates button throws an error on unsupported platforms #317

DinCahill opened this issue Feb 21, 2022 · 0 comments
Labels

Comments

@DinCahill
Copy link
Contributor

OS
Linux (non-AppImage)
Development builds (any OS)

Gmail Desktop Version
v3.0.0-alpha.34

Describe the bug
When using the deb package, the "Check for Updates" button throws an error because app-update.yml does not exist.

When developing via npm run start, it's dev-app-update.yml instead.

Steps to reproduce the behavior

  1. Click the top-left menu > Gmail Desktop > Check for Updates...
  2. Error message appears

Expected behavior
The option should not be shown, or should not throw an error.

Media
electron-updater error
20220221-172616_electron

Additional context
This presumably affects anything not supported by electron-updater: deb, rpm, Arch etc.

I tried simply checking if path.join(app.getAppPath(), '..', 'app-update.yml') exists, and that worked as expected on Windows, Mac, Linux AppImage, and Linux deb.


For testing electron-updater in development, the documentation says this:

Note that in order to develop/test UI/UX of updating without packaging the application you need to have a file named dev-app-update.yml in the root of your project, which matches your publish setting from electron-builder config (but in yaml format). But it is not recommended, better to test auto-update for installed application (especially on Windows). Minio is recommended as a local server for testing updates.

Example dev-app-update.yml for GitHub:

provider: github
owner: timche
repo: gmail-desktop
channel: dev
@DinCahill DinCahill added the bug label Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant