fix(on-reducer-explicit-return-type): return primitives

Closes #38

src/rules/ngrxOnReducerExplicitReturnTypeRule.ts

@@ -24,19 +24,21 @@ export class Rule extends Lint.Rules.TypedRule {
   ): Lint.RuleFailure[] {
     const creators = tsquery(
       sourceFile,
-      'CallExpression:has(Identifier[name=createReducer])  CallExpression:has(Identifier[name=on]) > ArrowFunction:not(:has(TypeReference),:has(CallExpression))',
-    ) as ts.CallExpression[]
+      'CallExpression[expression.name="createReducer"] > CallExpression[expression.name="on"] > ArrowFunction:not(:has(CallExpression))',
+    ) as ts.ArrowFunction[]
 
-    const failures = creators.map(
-      (node): Lint.RuleFailure =>
-        new Lint.RuleFailure(
-          sourceFile,
-          node.getStart(),
-          node.getStart() + node.getWidth(),
-          Rule.FAILURE_STRING,
-          this.ruleName,
-        ),
-    )
+    const failures = creators
+      .filter(node => !node.type)
+      .map(
+        (node): Lint.RuleFailure =>
+          new Lint.RuleFailure(
+            sourceFile,
+            node.getStart(),
+            node.getStart() + node.getWidth(),
+            Rule.FAILURE_STRING,
+            this.ruleName,
+          ),
+      )
     return failures
   }
 }

test/rules/ngrx-on-reducer-explicit-return-type/fixture.ts.lint

@@ -84,6 +84,16 @@ on(
 
 )
 
+// https://github.com/timdeschryver/ngrx-tslint-rules/issues/38
+export const onlineStateReducer = createReducer<boolean>(
+  onlineInitialState,
+  on(appIsOnline, (_currentState, _action): boolean => {
+    return true;
+  }),
+  on(appIsOffline, (_currentState, _action): boolean => {
+    return false;
+  }),
+);
 
 [on-reducer-explicit-return-type]: On reducers should have an explicit return type when using arrow functions, on(action, (state):State => {}