fix: ngrx-action-hygiene should only verify action name in createActi…

…on (#23)

package.json

@@ -28,6 +28,7 @@
     "copy:schematics": "cp ./src/schematics/collection.json ./dist/schematics & cp ./src/schematics/ng-add/schema.json ./dist/schematics/ng-add",
     "generate-schema": "ts-node ./src/scripts/generate-schema.ts",
     "lint": "tslint -p .",
+    "build-and-test": "npm run build && npm run test:rules",
     "test": "npm run test:schematics && npm run test:rules",
     "test:schematics": "jest --config ./test/jest.config.json",
     "test:rules": "tslint --test ./test/rules/**/tslint.json",

src/rules/ngrxActionHygieneRule.ts

@@ -18,17 +18,27 @@ export class Rule extends Lint.Rules.TypedRule {
   public static FAILURE_STRING =
     'Action type does not follow the good action hygiene practice, use "[Source] Event" to define action types'
 
+  private static ACTION_CREATOR_QUERY =
+    'CallExpression > Identifier[name=/createAction.*/]'
+
   public applyWithProgram(
     sourceFile: ts.SourceFile,
     program: ts.Program,
   ): Lint.RuleFailure[] {
-    const creators = tsquery(
-      sourceFile,
-      `CallExpression:has(Identifier[name=/createAction.*/]) > StringLiteral`,
-    )
-    const hits = creators.filter(
-      (node): boolean => !node.getText().match(/[\[].*[\]]\s.*/),
-    )
+    const creators = tsquery(sourceFile, Rule.ACTION_CREATOR_QUERY)
+    const hits = creators
+      .map(({ parent }) => {
+        if (!ts.isCallExpression(parent)) {
+          return undefined
+        }
+
+        return tsquery(parent, 'StringLiteral')[0]
+      })
+      .filter(
+        actionTypeNode =>
+          actionTypeNode && !/[\[].*[\]]\s.*/.test(actionTypeNode.getText()),
+      )
+
     const failures = hits.map(
       (node): Lint.RuleFailure =>
         new Lint.RuleFailure(

test/rules/ngrx-action-hygiene/fixture.ts.lint

@@ -38,4 +38,18 @@ const action = createAction(
 
 const action = createAction('[Customers] load', ( page: number ) => ({ page }))
 
+
+// https://github.com/timdeschryver/ngrx-tslint-rules/issues/22
+describe("application reducers", () => {
+  describe("appInit reducers", () => {
+    it("should return the initial state", () => {
+      let newState = initializationStateReducer(undefined, createAction("[App Tests] Init"));
+      expect(newState).toEqual(appInitInitialState);
+
+      newState = initializationStateReducer(undefined, initializeApplication);
+      expect(newState).toEqual(appInitInitialState);
+    });
+  });
+});
+
 [action-hygiene]: Action type does not follow the good action hygiene practice, use "[Source] Event" to define action types