Skip to content
This repository has been archived by the owner on May 23, 2021. It is now read-only.

ngrx-on-reducer-explicit-return-type matches nested arrow functions #37

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

StephenCooper
Copy link
Contributor

Currently this inner function will error with the ngrx-on-reducer-explicit-return-type rule. This should not be the case and rule should only match on reducer callback functions.

on(
  increment,
  (s): State => ({
    ...s,
    counter: (s => s.counter + 1)(s),
  }),
),

Copy link
Owner

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@timdeschryver timdeschryver merged commit 805b9e1 into timdeschryver:master Jun 1, 2020
@timdeschryver
Copy link
Owner

🎉 This PR is included in version 2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@StephenCooper
Copy link
Contributor Author

Looks this this fix was already made in the eslint version of the rule. :)

@timdeschryver
Copy link
Owner

Seems like we have, timdeschryver/eslint-plugin-ngrx#26! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants