Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeErrors: "global" undefined in modules #229

Closed
christianvoigt opened this issue Aug 3, 2014 · 1 comment
Closed

Uncaught TypeErrors: "global" undefined in modules #229

christianvoigt opened this issue Aug 3, 2014 · 1 comment

Comments

@christianvoigt
Copy link

Hi, after updating to 1.3 every module throws the following error: "Uncaught TypeError: Cannot read property 'rangy' of undefined".

The problem is caused by "factory(global.rangy);" Global is undefined.

Seems to me, you forgot to set global in your builder in copyModuleScripts, right? The first function in your factory pattern expects two parameters: factory and global. But only the factory parameter is set.

@timdown
Copy link
Owner

timdown commented Aug 3, 2014

Oops. Yes, you're absolutely right. I've fixed that and created a new release. Thanks.

@timdown timdown closed this as completed Aug 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants