fix: remove sqlalchemy warning about conflicts #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Askir
force-pushed
the
jascha/ai-423-bug-fix-sqlalchemy-relationship-warning-in-model
branch
from
e4eae40 to
6180362
Compare
adolsalamanca
approved these changes
Jan 29, 2025
Askir
deleted the
jascha/ai-423-bug-fix-sqlalchemy-relationship-warning-in-model
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #406
Functionally this doesn't change anything. It just makes it so that if you would somehow attach an embedding to a different parent entity the
.parentis correctly changed as well. However I don't see this as a valid use-case since the vectorizer is in charge of keeping the embeddings in sync. Therefore I didn't write a test for this, and just added the line to remove the warning by sqlalchemy in the log.