Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plain-text password #18

Closed
bricklen opened this issue Apr 10, 2017 · 3 comments
Closed

Plain-text password #18

bricklen opened this issue Apr 10, 2017 · 3 comments

Comments

@bricklen
Copy link

In https://github.com/timescale/timescaledb/blob/master/sql/common/tables.sql there is a comment on the _timescaledb_catalog.cluster_user table.

CREATE TABLE IF NOT EXISTS _timescaledb_catalog.cluster_user (
    username TEXT NOT NULL PRIMARY KEY,
    password TEXT NULL --not any more of a security hole than usual since stored in  pg_user_mapping anyway
);

That comment is only partially accurate. The pg_catalog.pg_user_mapping table is viewable only by super users, whereas the cluster_user table appears to be viewable by non-superusers.
Are there plans to restrict access to that table, or more specifically, to the password column?

@cevian
Copy link
Contributor

cevian commented Apr 11, 2017

Yes, we plan to lock down these tables in the future. The clustering stuff in general is subject to a lot of flux for now. (we are concentrating only on single-node at the moment, clustering is not supported officially yet). In single-node use this table does not need to be populated.

@bricklen
Copy link
Author

Sounds good. Thanks for clarifying.
I have a couple PR's up, but the only important one is #17. I understand the code is in flux (it's beta after all), so no worries if you want to decline or modify the changes.
Cheers!

@cevian
Copy link
Contributor

cevian commented Apr 11, 2017

Yeah we are trying to finish up the contributor agreement and external PR approach. But we really appreciate alls the PRs! We'll respond to them shortly.

Thanks,
Mat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants