Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't invalidate relation cache if cagg watermark constify is false #7492

Merged

Conversation

fabriziomello
Copy link
Contributor

@fabriziomello fabriziomello commented Nov 26, 2024

It is not necessary to invalidate the relation cache during the watermark update if the GUC enable_cagg_watermark_constify=false. Was a leftover when the feature was introduced by #6325.

Disable-check: force-changelog-file
Disable-check: approval-count

Copy link

@svenklemm, @mkindahl: please review this pull request.

Powered by pull-review

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.17%. Comparing base (59f50f2) to head (55e7512).
Report is 635 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7492      +/-   ##
==========================================
+ Coverage   80.06%   82.17%   +2.10%     
==========================================
  Files         190      230      +40     
  Lines       37181    43190    +6009     
  Branches     9450    10869    +1419     
==========================================
+ Hits        29770    35491    +5721     
- Misses       2997     3380     +383     
+ Partials     4414     4319      -95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabriziomello fabriziomello enabled auto-merge (rebase) November 26, 2024 19:49
@fabriziomello fabriziomello force-pushed the cagg_watermark_constify_leftover branch 2 times, most recently from 656d8ff to 394d683 Compare November 29, 2024 20:59
Copy link
Contributor

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/ts_catalog/continuous_aggs_watermark.c Outdated Show resolved Hide resolved
@fabriziomello fabriziomello force-pushed the cagg_watermark_constify_leftover branch from 394d683 to 05b986a Compare December 2, 2024 12:56
It is not necessary to invalidate the relation cache during the
watermark update if the GUC `enable_cagg_watermark_constify=false`. Was
a leftover when the feature was introduced by timescale#6325.
@fabriziomello fabriziomello force-pushed the cagg_watermark_constify_leftover branch from 05b986a to 55e7512 Compare December 2, 2024 20:00
@fabriziomello fabriziomello merged commit 02b76fa into timescale:main Dec 2, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants