Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] sinon mock of setIntermediate breaks subscribe #62

Closed
JulesAU opened this issue Mar 1, 2018 · 2 comments
Closed

[docs] sinon mock of setIntermediate breaks subscribe #62

JulesAU opened this issue Mar 1, 2018 · 2 comments

Comments

@JulesAU
Copy link

JulesAU commented Mar 1, 2018

I just spent hours trying to figure out why job subscriptions weren't working when running in my mocha test harness.

Turns out my use of sinon to mock timers was interfering with the setImmediate call in Manager.

Others have had this problem with sinon; obviously it's not a pg-boss issue, but might be worth putting in the docs to save someone else tearing their hair out in future :-)

Cheers

@timgit
Copy link
Owner

timgit commented Mar 1, 2018

🤔 That's interesting. Do you have an example of how others have "documented" this? I see a couple issues linked from your linked issue, but I don't understand what you're proposing here. How about I just close this issue like the other deps have and we're good? 😀

@JulesAU JulesAU changed the title [docs] Doesn't play nice with sinon [docs] sinon mock of setIntermediate breaks subscribe Mar 1, 2018
@JulesAU
Copy link
Author

JulesAU commented Mar 1, 2018

Yeah you're right. I've made the issue title more Google friendly; so hopefully if someone is having similar trouble they'll find this issue.

Closing :-)

@JulesAU JulesAU closed this as completed Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants