Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pkg to testnames #4

Closed
staticfloat opened this issue May 14, 2015 · 6 comments
Closed

Adding pkg to testnames #4

staticfloat opened this issue May 14, 2015 · 6 comments

Comments

@staticfloat
Copy link
Member

@timholy After merging the selection of testnames into base Julia, we have discovered a test that we want to run in the coverage suite; pkg. Should we change choosetests.jl to include an option that we can set somehow to ensure pkg gets run, or should we add some logic here to get that test to run? We already run the pkg test manually on travis.

@timholy
Copy link
Member

timholy commented May 14, 2015

I guess the reason it's not part of the regular test suite is to prevent spurious failures in not-connected systems? I wasn't involved in that decision, so I'm only guessing.

I don't really have strong feelings about how it should be implemented. If you want to tweak stuff here, that's fine with me. (I'm also happy transferring this package to you or julialang, if that's preferable.)

@staticfloat
Copy link
Member Author

Yes, precisely. It fails on things like Canonical's buildd servers, because those do not have internet connectivity.

Since you don't have strong feelings about it, (and with my new god-like push powers to this repo) I'll just write something that I can live with. Thanks!

@timholy
Copy link
Member

timholy commented May 14, 2015

Enjoy it, new god 😄. You have some recent companions, too.

@kshyatt
Copy link
Collaborator

kshyatt commented May 14, 2015

Now I can try to figure out why my Coveralls is showing 60% coverage, while the JuliaLang one is correctly showing 76%. Bizarre.

@kshyatt
Copy link
Collaborator

kshyatt commented May 15, 2015

I ran my own Coveralls with pkg enabled - it should bump us up to ~77.5%

@timholy
Copy link
Member

timholy commented Jun 14, 2015

Closed by b3b0615

@timholy timholy closed this as completed Jun 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants