-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding pkg
to testnames
#4
Comments
I guess the reason it's not part of the regular test suite is to prevent spurious failures in not-connected systems? I wasn't involved in that decision, so I'm only guessing. I don't really have strong feelings about how it should be implemented. If you want to tweak stuff here, that's fine with me. (I'm also happy transferring this package to you or julialang, if that's preferable.) |
Yes, precisely. It fails on things like Canonical's buildd servers, because those do not have internet connectivity. Since you don't have strong feelings about it, (and with my new god-like push powers to this repo) I'll just write something that I can live with. Thanks! |
Enjoy it, new god 😄. You have some recent companions, too. |
Now I can try to figure out why my Coveralls is showing 60% coverage, while the JuliaLang one is correctly showing 76%. Bizarre. |
I ran my own Coveralls with |
Closed by b3b0615 |
@timholy After merging the selection of testnames into base Julia, we have discovered a test that we want to run in the coverage suite;
pkg
. Should we changechoosetests.jl
to include an option that we can set somehow to ensurepkg
gets run, or should we add some logic here to get that test to run? We already run thepkg
test manually on travis.The text was updated successfully, but these errors were encountered: