Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests did not pass #313

Closed
iajzenszmi opened this issue May 4, 2024 · 5 comments
Closed

Some tests did not pass #313

iajzenszmi opened this issue May 4, 2024 · 5 comments

Comments

@iajzenszmi
Copy link

Screenshot from 2024-05-04 13-48-11
image
Screenshot from 2024-05-04 13-48-11
now 0.01: Time: 0:00:06 (101 iterations)
Testing rounding (#300)
Progress: 100%|██████████████████████████| Time: 0:00:06
percentage: 100.0
Test Summary: | Pass Fail Total Time
Core | 102 1 103 2m48.1s
ERROR: LoadError: Some tests did not pass: 102 passed, 1 failed, 0 errored, 0 broken.
in expression starting at /home/ian/.julia/packages/ProgressMeter/dMfiC/test/runtests.jl:9
ERROR: Package ProgressMeter errored during testing

@MarcMush
Copy link
Collaborator

MarcMush commented May 4, 2024

What test is failing? Is it the performance test? It is not very reliable (#219)

@iajzenszmi
Copy link
Author

iajzenszmi commented May 4, 2024

Screenshot from 2024-05-04 21-28-57
Progress: 100%|██████████████████████████| Time: 0:00:07
Core: Test Failed at /home/ian/.julia/packages/ProgressMeter/dMfiC/test/core.jl:51
Expression: #= /home/ian/.julia/packages/ProgressMeter/dMfiC/test/core.jl:51 =# @Elapsed(prog_perf(10 ^ 7)) < 9 * #= /home/ian/.julia/packages/ProgressMeter/dMfiC/test/core.jl:51 =# @Elapsed(noprog_perf(10 ^ 7))
Evaluated: 7.015894863 < 0.156777642.
The prog_perf test is problematic here.

Stacktrace:
[1] macro expansion
@ ~/.julia/juliaup/julia-1.10.3+0.x64.linux.gnu/share/julia/stdlib/v1.10/Test/src/Test.jl:672 [inlined]
[2] top-level scope

@MarcMush
Copy link
Collaborator

MarcMush commented May 4, 2024

That's an annoying one, the number 9 chosen is arbitrary for deciding what performance hit is acceptable
It never passes on my reasonably performant and recent windows machine

@MarcMush
Copy link
Collaborator

MarcMush commented May 4, 2024

However 9s seem very long so there might be a problem somewhere

@MarcMush
Copy link
Collaborator

closed in favour of #323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants